Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drops max count #10713

Merged
merged 27 commits into from
Aug 15, 2024
Merged

fix: drops max count #10713

merged 27 commits into from
Aug 15, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Aug 1, 2024 •
edited by hassnian
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 1, 2024 •
edited
Loading

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74c9bd5
Status: ✅  Deploy successful!
Preview URL: https://e24c53e9.kodaart-production.pages.dev
Branch Preview URL: https://fix--drops-max-count.kodaart-production.pages.dev

View logs

@netlify Netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 74c9bd5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66bdac04932f7d000819f386
😎 Deploy Preview https://deploy-preview-10713--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@preschian
refactor(tests): simplify image loading wait logic in explore.spec.ts
c25e266
@preschian
feat(tests): ensure images load during scroll in e2e explore
5f4bf39
@preschian
refactor(tests): update collection spec to new data and optimize wait…
5e481d8 
… times

- Updated collection address and name constants.
- Added additional wait for network idle state.
- Removed redundant sale filter checks.
@preschian
chore(workflow): increase shard count in Playwright configuration
c0cbc89
@preschian
chore(tests): add network idle state wait in gallery item interaction…
ac63e8b 
…s test
@preschian
feat(playwright): increase timeout and ensure server start command
9836743 
refactor(e2e): wait for network to be idle in drops page tests
@preschian
feat(playwright): increase timeout settings and add expect timeout
44c96a0 
refactor(e2e): remove unnecessary Commands parameter and comment out unused function call
@preschian preschian marked this pull request as ready for review August 1, 2024 08:20
@preschian preschian requested a review from a team as a code owner August 1, 2024 08:20
@preschian preschian requested review from Jarsen136 and hassnian and removed request for a team August 1, 2024 08:20
@preschian
Copy link
Member Author

Hmm, I think the limited specs of the current runner cause flaky tests from e2e. Since running e2e tests is quite heavy, we need to increase the specs: https://docs.github.com/en/actions/using-github-hosted-runners/about-larger-runners/about-larger-runners

@preschian preschian mentioned this pull request Aug 1, 2024
Open
@vikiival
Copy link
Member

vikiival commented Aug 2, 2024

Please can you do the test fixes and and max count in two separated prs?

@preschian
Copy link
Member Author

Please can you do the test fixes and and max count in two separated prs?

sure, let me revert first

hassnian
hassnian approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

cc @vikiival since he posted https://github.com/kodadot/ops-internal/discussions/1745#discussioncomment-9892060

@vikiival
Copy link
Member

vikiival commented Aug 4, 2024

sure, let me revert first

waiting for

the test fixes

@preschian
Merge branch 'main' of github.com:kodadot/nft-gallery into fix--drops…
515f22d 
…-max-count
@preschian
feat(drop): integrate EVM and Substrate collection data handling
6cdf1a8 
refactor(onchain): abstract EVM and Substrate collection fetch logic into utility files

chore(dependencies): add @farcaster/auth-client to project dependencies
@preschian
refactor(mint-button): add null check for maxCount comparison
841d325
@preschian preschian mentioned this pull request Aug 5, 2024
Merged
5 tasks
@preschian
refactor(drop): replace collection entity references with drop
916e98c 
- Refactor to access `collectionName`, `collectionDescription`, `max`, and `minted` directly `drop`.
- Remove unused imports and streamline state management for components.
- Update types and store defaults to ensure proper interface for `drop` data.
@preschian
refactor(drop): replace useDrop with storeToRefs to streamline state
ae281ab
@preschian
Merge branch 'main' of github.com:kodadot/nft-gallery into fix--drops…
ca3ac44 
…-max-count
@preschian
refactor(generative-drop): correct typos in function names and fix me…
631991e 
…tadata assignment

feat(modal-tracker): add error handling to modal state watcher
@preschian
Copy link
Member Author

Updates: I refactored some stuff on composable for drops. and, I just found out that this composable prevents the user from closing the modal composables/useModalIsOpenTracker.ts

@preschian preschian requested review from hassnian and Jarsen136 August 8, 2024 04:23
@Jarsen136
Copy link
Contributor

Updates: I refactored some stuff on composable for drops. and, I just found out that this composable prevents the user from closing the modal composables/useModalIsOpenTracker.ts

I also find this error when I'm working on another issue. Here is how I solved it. WDYT 643eb8e

hassnian
hassnian reviewed Aug 8, 2024
View reviewed changes
utils/onchain/evm.ts Outdated Show resolved Hide resolved
hassnian
hassnian approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small, otherwise LGTM

@preschian
Copy link
Member Author

I also find this error when I'm working on another issue. Here is how I solved it. WDYT 643eb8e

oh, I like yours

@hassnian hassnian mentioned this pull request Aug 14, 2024
Closed
@hassnian
Copy link
Contributor

added #10804 see context

@preschian you've got some conflicts
@vikiival can we merge,

@vikiival
Copy link
Member

@vikiival can we merge,
Y

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@preschian
Copy link
Member Author

merging this~

@preschian preschian added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit 8b78c40 Aug 15, 2024
23 checks passed
@preschian preschian deleted the fix--drops-max-count branch August 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All Base drop shows only 1 minted NFT Drops max count mismatch for a moment
4 participants
@preschian @vikiival @Jarsen136 @hassnian